MonashBioinformaticsPlatform / RNAsik-pipe

RNAsik - more than just a pipeline
https://monashbioinformaticsplatform.github.io/RNAsik-pipe/
Apache License 2.0
13 stars 5 forks source link

Prototype sabre - demultiplexing addition to RNAsik #32

Open serine opened 5 years ago

serine commented 5 years ago

Hi world,

Putting this out there hoping that somebody can get involved and write this bit of code for me :) :+1: . This is great way to get involved with open-source, learn and practice not only code writing by PR (pull request) submission, code review and perhaps some git rebasing - so that this new feature comes as a single unit. Don't be afraid if you haven't done this below, just fork the repo and see if you can make this bit of code to work. I can help you with the rest.

Below I've tried to described as detailed as I could what's needs doing in a step by step manner.

sikFqFiles.bds:18:    string fqDir = sikDir+"/"+"fastqDir/"
sikTrim.bds:13:    string trimedDir = sikDir+"/"+"fastqDir/trimed"
diff --git a/src/RNAsik.bds b/src/RNAsik.bds
index 83beaaf..65924c8 100644
--- a/src/RNAsik.bds
+++ b/src/RNAsik.bds
@@ -62,7 +62,14 @@ string{} usrOpts = getUsrOpts(extraOpts)

 string[] fqFiles
 if(!fqDir.isEmpty()) {
-    fqFiles = getFqFiles(cmdExe, fqDir, extn, sikDir)
+
+    if(demult) {
+        fqFile = getDemultFqFiles(....)
+    }
+    else {
+        fqFiles = getFqFiles(cmdExe, fqDir, extn, sikDir)
+    }
+
     mkLog("fqFiles", parseList(fqFiles), "samples", logsDir)

     if(trim) {

in fact for cleaner code perhaps move if(trim) into if else(trim) block. As in try demultiplexing, then try trimming, then simply get fastq files from fqDir path

Also need to think about some test cases

cheers