MonashProteomics / FragPipe-Analyst

GNU General Public License v3.0
9 stars 4 forks source link

Volcano plot visualization revisit #63

Closed hsiaoyi0504 closed 1 year ago

hsiaoyi0504 commented 1 year ago
hsiaoyi0504 commented 1 year ago

It looks like only relies on the significant column, which is not appropriate, should be based on the actual p-value column since users can toggle p val and adj,p. https://github.com/MonashProteomics/FragPipe-Analyst/blob/ffb3a9d7f83eaa2a9b5b0f350c599413fd34de1a/R/volcano_function.R#L385-L390

hsiaoyi0504 commented 1 year ago

Should be finished in #75.