Closed watilde closed 9 years ago
Thanks! Just one request, which is to keep naming conventions consistent, I have a couple of rules for how we name variables.
Temporary, local variables are prefixed with 't' and file-wide or closure-wide members are prefixed with 'm'. Parameters to functions are prefixed with 'p'. require'd files can just be the name of the file like normal though as if it was an external library.
So for example your message
variable would be renamed tMessage
or mMessage
.
I'll merge this after those guidelines are met.
@Moncader Thanks for your review and seems good rules! I just fixed that. Well, I think maybe it's better to put CONTRIBUTING.md for writing them:)
@watilde I'll add the rules in to the proper file once I get a bit of time! Thanks!
@Moncader Sorry for my overlooked, I've fixed for now at https://github.com/watilde/rejs/commit/5d07507aacd9bf6e675493c2315f8f4649cda89e Thanks :smiley_cat:
Hi @Moncader
I added cli for npm. Its behavior is the following:
Print help message
Print rejs version
Output to stdout
Output to single file
Could you please any thought on this please? Thanks.