search

MoneroOcean / node-cryptoforknote-util

NodeJS wrappers for Cryptonode/Forknote coins
12 stars 84 forks source link

compilation error with GCC 6 and 7 #1

Closed grunjol closed 6 years ago

grunjol commented 6 years ago

This happens with most of the forks of node-cryptonote-util, and lot of people already sent PR on those forks, its a simple C struct name declaration

Issue https://github.com/zone117x/node-cryptonote-pool/issues/175 PR (on Snipa22 branch): https://github.com/Snipa22/node-cryptonote-util/pull/2 that solves the issue.

I'v been using that patch in my production servers with GCC 6 and 7 without any problem.

MoneroOcean commented 6 years ago

Thanks for letting me know. Fix was applied: https://github.com/MoneroOcean/node-cryptoforknote-util/commit/26c6ff80758f3b6c8aeb191f13527676af46c079

grunjol commented 6 years ago

That was fast! I can compile xmr-node-proxy now without any custom modification on AESNI (and non-) on GCC 5, 6 and 7.

Thanks