MoneroOcean / node-cryptoforknote-util

NodeJS wrappers for Cryptonode/Forknote coins
12 stars 84 forks source link

convert_blob fails with bytecoin #8

Open muscleman opened 4 years ago

muscleman commented 4 years ago

running the following development branch with a fully sync'd bytecoin daemon.

https://github.com/dvandal/cryptonote-nodejs-pool/tree/development

the following config should work.

https://github.com/dvandal/cryptonote-nodejs-pool/blob/development/config_examples/bbscoin.json

I also forked node-cryptoforknote-util and added a bunch of debugging outputs. Appears a proof is failing to serialize

https://github.com/muscleman/node-cryptoforknote-util/blob/master/src/serialization/vector.h#L60

muscleman commented 4 years ago

If when generating the pool wallet i specify --wallet-type=legacy and use this wallet for the pool. Seems everything is fine. miners can mine to the pool with amethyst type wallets.

So I'm not sure if this is a bug or not.

muscleman commented 4 years ago

I applied 2 patches from the bytecoin team to a fork of your repository and the changes appear to work. Is there anyway to make these changes mainstream in your repo? https://github.com/muscleman/node-cryptoforknote-util

ghost commented 3 years ago

Same problem here. convert_blob works with legacy address but not with amethyst... @muscleman Can you tell me where these 2 patches are? Thank you.