search

MoneroOcean / xmrig

Monero (rx/0, rx/wow, rx/loki, defyx, rx/arq, rx/sfx, rx/keva, cn/0, cn/1, cn/2, cn/r, cn/fast, cn/half, cn/xao, cn/rto, cn/rwz, cn/zls, cn/double, cn/gpu, cn-lite/0, cn-lite/1, cn-heavy/0, cn-heavy/tube, cn-heavy/xhv, cn-pico, cn-pico/tlo, argon2/chukwa, argon2/wrkz, astrobwt) CPU/GPU miner
https://moneroocean.stream
GNU General Public License v3.0
275 stars 86 forks source link

No shares accepted (or even sent?) starting with release v6.21.3-mo5 #131

Closed Fjodor42 closed 5 months ago

Fjodor42 commented 5 months ago

Describe the bug A number of releases where made recently, but starting with v6.21.3-mo5, I get no messages of "accepted", and node doesn't get displayed at the pool dashboard.

In effect, even thought he code compiles, and xmrig seems to run, no shares seem to be accepted, possibly because they are never sent.

Suspicion is that the benchmark changes were somehow too invasive, somehow managing to convince that after benchmarks, from which I assume that shares should not not be sent, no real shares are ever sent either.

To Reproduce Compile and run release v6.21.3-mo5 or any of the ones that followed.

Expected behavior Running xmrig would benchmark, the proceed to find and send shares.

Required data

Spudz76 commented 5 months ago

Seems like it's because this one line was removed from MoBenchmark::finish

Without the listener restored to normal, it can't validate or submit results.

diff --git a/src/core/MoBenchmark.cpp b/src/core/MoBenchmark.cpp
index ddfb03eca..fba92449c 100644
--- a/src/core/MoBenchmark.cpp
+++ b/src/core/MoBenchmark.cpp
@@ -56,6 +56,7 @@ void MoBenchmark::finish() {
     LOG_INFO("%s " BRIGHT_BLACK_BG(CYAN_BOLD_S " ALGO PERFORMANCE CALIBRATION COMPLETE "), Tags::benchmark());
     m_controller->miner()->pause(); // do not compute anything before job from the pool
     JobResults::stop();
+    JobResults::setListener(m_controller->network(), m_controller->config()->cpu().isHwAES());
     m_controller->start();
 }
Spudz76 commented 5 months ago

Confirmed that fixes it after running for a bit.

realsetvin commented 5 months ago

Confirmed that fixes it after running for a bit.

was this fixed in the new version released?

Spudz76 commented 5 months ago

was this fixed in the new version released?

Nope. Needs a mo9 release with the fix merged. I also have a couple other PR's cooking that could go into mo9 as well but aren't quite as totally broken.

EDIT: okay I think most of the PR's are done and posted @MoneroOcean

serisman commented 5 months ago

Seems like it's because this one line was removed from MoBenchmark::finish

Thanks for the patch. I can confirm it seems to fix the issue of shares not being accepted (on mo8) on my test system as well.