search

MonetDB / MonetDBLite-C

MonetDB as a shared library with a C API
33 stars 14 forks source link

Changes for MonetDBJavaLite compilation #2

Closed PedroTadim closed 6 years ago

PedroTadim commented 7 years ago

Here are all my changes for the native code compilation for MonetDBJavaLite. Any question please ask. Thanks!

hannes commented 6 years ago

Please make sure the travis build passes with the changes in this PR

hannes commented 6 years ago

Please merge again, also note the trick in the Makefile to avoid the pthreads dependency

PedroTadim commented 6 years ago

I have merged the changes, but I get a problem on linking with your flags. I am distributing the libwinpthread-1.dll, and I am having no problems. I have just fixed all the points.

hannes commented 6 years ago

Great that it passes now. I have one more request: Every change creates a liability for future merges, so could you check these changes are minimal?

hannes commented 6 years ago

Also, whats the problem when linking?!

PedroTadim commented 6 years ago

Actually I had the mingw64-winpthreads-static package missing :), so that's fixed. The only thing left to fix is the monetdb_query result. I simplified it, but I guess you want the query result type passed as a parameter.