search

MonetDB / MonetDBLite-R

MonetDB reconfigured as an R package - See below for an introduction. Edit
64 stars 13 forks source link

Add support for more window functions #19

Closed edgararuiz-zz closed 6 years ago

edgararuiz-zz commented 6 years ago

I'm getting a warning everytime I run a query using dplyr. It looks like median needs to be added to the window functions:

Warning message:
Translator is missing window variants of the following aggregate functions:
* median

The message makes sense because I can see the function in the aggregate section:

https://github.com/hannesmuehleisen/MonetDBLite-R/blob/master/R/dplyr.R#L28

But is not in the window section.

hannes commented 6 years ago

Its not in the window section because MonetDB[Lite] does only have limited window functions support.

hannes commented 6 years ago

MIN/MAX/SUM/MEDIAN/AVG Anything I forgot?

edgararuiz-zz commented 6 years ago

Ok, I'm just getting median in the message, so I'm not sure if adding the other would hurt/help. BTW - Not sure if this is what you plan to do, but I believe that adding win_absent() will both cover the message and let the user that median is not supported for windowed functions

hannes commented 6 years ago

great idea, thanks, added