MonetDB / pymonetdb

The Python API for MonetDB
https://www.monetdb.org/
Mozilla Public License 2.0
28 stars 20 forks source link

fix cutoff long packets with utf-8 characters #16

Closed basbloemsaat closed 7 years ago

basbloemsaat commented 7 years ago

In python3 encode was applied after after splicing the string. With encode, utf-8 characters are potentially expanded to multiple octets. For a given block that exceeded MAX_PACKAGE_LENGTH this resulted in the last few octets falling off a package.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 87.117% when pulling aeb28495e32a0be6d7dd0f6678d8cefcee787b94 on basbloemsaat:fix_utf8_packet_cutoff into c9c92205508e0bfa09a2f6cde665e0795437aff7 on gijzelaerr:master.

basbloemsaat commented 7 years ago

It seems the travis fail on 2.6 is unrelated:

$ sphinx-build -b html -d _build/doctrees -W  . _build/html
Error: Sphinx requires at least Python 2.7 or 3.4 to run.
gijzelaerr commented 7 years ago

thanks!