search

MonetDB / pymonetdb

The Python API for MonetDB
https://www.monetdb.org/
Mozilla Public License 2.0
28 stars 20 forks source link

In python3 next has been renamed to __next__ #17

Closed basbloemsaat closed 7 years ago

basbloemsaat commented 7 years ago

https://www.python.org/dev/peps/pep-3114/

Without this change

for row in cursor:
    etc

would give an error

 TypeError: iter() returned non-iterator of type 'Cursor'
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.006% when pulling 5de3ef65d117c0fcfc99d6a8305f463d9fe502f5 on basbloemsaat:python_3_cursor_iterator into c9c92205508e0bfa09a2f6cde665e0795437aff7 on gijzelaerr:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.006% when pulling 5de3ef65d117c0fcfc99d6a8305f463d9fe502f5 on basbloemsaat:python_3_cursor_iterator into c9c92205508e0bfa09a2f6cde665e0795437aff7 on gijzelaerr:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.09%) to 87.006% when pulling 5de3ef65d117c0fcfc99d6a8305f463d9fe502f5 on basbloemsaat:python_3_cursor_iterator into c9c92205508e0bfa09a2f6cde665e0795437aff7 on gijzelaerr:master.

gijzelaerr commented 7 years ago

hi @basbloemsaat, thanks for your PR! Can you maybe add a test to the test suite to verify it now works with all pythons? I would then merge it and make a new release (1.0.5).

basbloemsaat commented 7 years ago

Of course, I will do so after the weekend.

On 30 Dec 2016 10:51 a.m., "Gijs Molenaar" notifications@github.com wrote:

hi @basbloemsaat https://github.com/basbloemsaat, thanks for your PR! Can you maybe add a test to the test suite to verify it now works with all pythons? I would then merge it and make a new release (1.0.5).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gijzelaerr/pymonetdb/pull/17#issuecomment-269752442, or mute the thread https://github.com/notifications/unsubscribe-auth/ABg2tMzX9VxoQUcTmm5vWISAAYfYTSClks5rNNQwgaJpZM4LU2ZP .

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.7%) to 87.786% when pulling 07950f2ec9123420d0022f07d0e275b0f41a6ccd on basbloemsaat:python_3_cursor_iterator into c9c92205508e0bfa09a2f6cde665e0795437aff7 on gijzelaerr:master.

basbloemsaat commented 7 years ago

It took two weeks longer, sorry about that. Cheers!

gijzelaerr commented 7 years ago

no problem! awesome.

gijzelaerr commented 7 years ago

made new 1.0.5 release:

https://github.com/gijzelaerr/pymonetdb/releases/tag/1.0.5

travis should push it soon to pypi. Enjoy! Thanks again.

basbloemsaat commented 7 years ago

Thank you!

On 20 Jan 2017 11:34, "Gijs Molenaar" notifications@github.com wrote:

made new 1.0.5 release:

https://github.com/gijzelaerr/pymonetdb/releases/tag/1.0.5

travis should push it soon to pypi. Enjoy! Thanks again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gijzelaerr/pymonetdb/pull/17#issuecomment-274038889, or mute the thread https://github.com/notifications/unsubscribe-auth/ABg2tMeTFxYnHAueZJ3pK3FWEAC0Y3M5ks5rUI2qgaJpZM4LU2ZP .