search

MoneyTools / MyMoney.Net

MyMoney is a rich client .NET ClickOnce application for managing your personal finances. It is written entirely in C# and is designed for programmers who want easy access to their data and who want to quickly and easily add their own features. Your data will not be locked up in some proprietary format, it is yours to do with as you like.
https://moneytools.github.io/MyMoney.Net/
70 stars 22 forks source link

Wrong flag next to account? #103

Closed andreva7 closed 1 year ago

andreva7 commented 1 year ago

I have a canadian currency account but it shows the US flag next to it. A little confusing ...

image

andreva7 commented 1 year ago

It seems the flag is not working at all anymore: I set the currency on one account that had it blank. Instantly all accounts had a US flag, no matter whether they were USD, CAD or blank. I then changed the display currency from USD to CAD, the flag is still US everywhere. Restarted the App, still same behaviour.

jpdup commented 1 year ago

I'll investigate

jpdup commented 1 year ago

I was not able to reproduce this bug. Can you share the screen that you see on "View->Currencies" for example here's mine image

andreva7 commented 1 year ago

@.***

@.***

From: jpdup @.> Sent: Wednesday, March 29, 2023 11:51 AM To: MoneyTools/MyMoney.Net @.> Cc: andreva7 @.>; Author @.> Subject: Re: [MoneyTools/MyMoney.Net] Wrong flag next to account? (Issue #103)

I was not able to reproduce this bug. Can you share the screen that you see on "View->Currencies" for example here's mine [image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F2709213%2F228638736-84cddbe5-8abb-4ea0-9c47-2c86bf12bd6e.png&data=05%7C01%7C%7C952a1712d02b4e185bb408db30868700%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638157126564240994%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Zf%2B3XQhDbJz8ArkmNUK1NJIN1zGnGDJsSh3q3YadRxw%3D&reserved=0

- Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMoneyTools%2FMyMoney.Net%2Fissues%2F103%23issuecomment-1489128575&data=05%7C01%7C%7C952a1712d02b4e185bb408db30868700%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638157126564240994%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tF0XvtOx0vgTCMtkFImLkuzZiojfguX5uNSxgp5Fc6U%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJBV66EQGATHFPYGXXYDOBLW6SAA5ANCNFSM6AAAAAAWL3THUU&data=05%7C01%7C%7C952a1712d02b4e185bb408db30868700%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638157126564240994%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ahmxlRp8Pkt7TnOyqyl%2Fgcadp%2B3cBti%2Fa8ShzA2sJJY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

jpdup commented 1 year ago

Not sure what that last comment was about

clovett commented 1 year ago

I was able to reproduce the problem with sample data. Since we default to USD, all sample accounts show "USD" on the right, but no flag, since the flag requires explicit currency be set. I fixed the problem with currency flag not showing up on accounts that have no currency specified, it should default to US dollar.

andreva7 commented 1 year ago

Culture code for CAD was set to en-US. I fixed that and canada flags show up now. Maybe add a warning or error if two currencies have the same culture code?

clovett commented 1 year ago

Note that if you enter a new row for Canadian dollars, it defaults to "en-CA", so I think this should be good for other users that didn't already have the CAD entered in the Currencies view.

image