Support importing existing Kafka clusters (fixes #64)

Mongey / terraform-provider-confluentcloud

A Terraform provider for managing resource in confluent.cloud

MIT License

109 stars 47 forks source link

Support importing existing Kafka clusters (fixes #64) #74

Closed benweint closed 3 years ago

benweint commented 3 years ago

This change should address the issue reported in #64 wherein it's not currently possible to import existing Kafka clusters.

The issue is that the read function for clusters requires both the cluster ID and the containing environment ID, which means that using the pass-through state importer function doesn't work.

I've addressed this by allowing clusters to be imported by passing an import ID of the form <environment ID>/<cluster ID>.

alexjplant commented 3 years ago

I'm running into the same exact issue... would love for this to be merged so that I can move forward with versioning Kafka infrastructure!

Mongey commented 3 years ago

Looks good. I changed the separator to be /, as this is more inline with other providers.

benweint commented 3 years ago

Awesome, thank you @Mongey!

alexjplant commented 3 years ago

Big thanks to both of you @Mongey and @benweint for hooking this up!