Mongey / terraform-provider-ksql

Terraform provider for managing KSQL queries
MIT License
10 stars 10 forks source link

More options for the HTTP client #9

Open NickLarsenNZ opened 4 years ago

NickLarsenNZ commented 4 years ago

While testing, I have an invalid certificate, and need to be able to skip TLS verification. We also need to be able to provide basic auth, so I wonder if the provider can have additional options, such as:

provider "ksql" {
   url = "https://localhost:8083"

   skip_tls_verification = true

   auth {
      type     = "basic"
      username = "user"
      password = "password"
   }
}
NickLarsenNZ commented 4 years ago

It looks like we'd need to adjust the ksql lib to be able to take in a custom HTTP client:

https://github.com/Mongey/ksql/blob/5c43a2bbee699b9d206d50451578bb61b75cd6bd/ksql/client.go#L33

NickLarsenNZ commented 4 years ago

Should I create an issue over in mongey/ksql ?