MongoEngine / eve-mongoengine

An Eve extension for MongoEngine ODM support
Other
39 stars 28 forks source link

Projection incorrect response #11

Closed mjrealm closed 9 years ago

mjrealm commented 10 years ago

When I set datasource projection to 0 and query a resource with projection 1, it doesn't return the field.

Flask ext.add_model(User, datasource={'projection': {'image': 0}})

Explicit request: /user?projection={"image":1} --> Should return User with "image"

http://python-eve.org/features.html#projection-filestorage

hellerstanislav commented 10 years ago

Hello, hm...i do not think pre-set datasource projections are honored at all...forgot about it when implementing projections on the url level :/

Thanks for this heads up!

If you are really into this issue, you could provide some pull request. If not, I will manage to fix this in next release v0.0.7.

SH

hellerstanislav commented 10 years ago

Hello again, just now i am testing this feature, but in Eve v0.4 the core merges default datasource projection 0 + client (url) projection 1 as projection=0. Are you 100% sure Eve (without eve-mongoengine) resolves that as 1? As I see, eve docs says that it should return the field, but the reality is IMHO different..

SH

mjrealm commented 10 years ago

Hi, Sorry for that. After a simple test using barebone(back to cerberus) Eve, the projection doesn't work as what the docs says..

On Tue, Oct 7, 2014 at 5:16 AM, Stanislav Heller notifications@github.com wrote:

Hello again, just now i am testing this feature, but in Eve v0.4 the core merges default datasource projection 0 + client (url) projection 1 as projection=0. Are you 100% sure Eve (without eve-mongoengine) resolves that as 1? As I see, eve docs says that it should return the field, but the reality is IMHO different..

SH

— Reply to this email directly or view it on GitHub https://github.com/hellerstanislav/eve-mongoengine/issues/11#issuecomment-58175049 .

mmellison commented 9 years ago

Under new management!

We are going to be re-writing a significant portion of the extension. Closing issue. When the new version is released and you feel this issue still has not been resolved, please feel free to open the issue.