search

MongoEngine / marshmallow-mongoengine

Mongoengine integration with marshmallow
MIT License
78 stars 34 forks source link

Fixing schema update() method in light of recent changes in marshmall… #2

Closed leebecker closed 3 years ago

leebecker commented 6 years ago

Marshmallow 3.0.0b7 changed function outputs in a breaking manner. One such change was the removal of the UnmarshalResult namedtuple in conjunction with better exception handling Functions that used to return an UnmarshalResult now just the data object instead of a data, errors pair.

In marshmallow-mongoengine, these changes break the update method in BaseSchema. There may be other things that need fixing, but I saw no way to raise the issue, so I've created this pull request instead.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 95.214% when pulling 77aaa4a7ff7978f57648db3dcc984433725b3f61 on leebecker:feature/update_w_marshmallow_3.0.0 into a168eb57010a47f4fca44ea51cf8b695c357bc41 on MongoEngine:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 95.214% when pulling 77aaa4a7ff7978f57648db3dcc984433725b3f61 on leebecker:feature/update_w_marshmallow_3.0.0 into a168eb57010a47f4fca44ea51cf8b695c357bc41 on MongoEngine:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 95.214% when pulling 77aaa4a7ff7978f57648db3dcc984433725b3f61 on leebecker:feature/update_w_marshmallow_3.0.0 into a168eb57010a47f4fca44ea51cf8b695c357bc41 on MongoEngine:master.