Improve project structure

Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika

http://www.monikaafterstory.com/

Other

1.18k stars 689 forks source link

Improve project structure #10078

Open Booplicate opened 1 year ago

Booplicate commented 1 year ago

We will handle this post r8

we have a lot of scripts laying around, it's hard to navigate, we should split our code in subfolders
we have weird naming convention (zz_, -, _), it doesn't help
mod assets could be cleaned up too

multimokia commented 1 year ago

Noting some constraints and what I can assume are conventions in place for load order. This may also be possible to aleviate using priority named folders which may also improve readabiliy and understanding of why things are labeled the way they are.

dreamscached commented 1 year ago

How can I help? Should we first finish #10080 first?

I think we should drop script- & zz_ naming yes, I could help with splitting stuff to files or organizing into folders.

Booplicate commented 1 year ago

First we need a good idea of how the structure should be. Probably split backend frameworks from general content (topics), UI should also be separated if it's not already. May also split longs scripts, but that's debatable.

@multimokia, what do you think we should do first, migrate to python or restructure the project?

multimokia commented 1 year ago

I would almost argue to do them in tandem but working on them together with multiple people could get conflict messy.

However, since migration would enforce a new structure for everything python, it may not be worth touching now in the interest of avoiding double work.

So, I think things that should probably remain mostly renpy (see: topics/a decent chunk of holidays) we should deal with so splitting that may be the better focus right now imo