Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 685 forks source link

piano should allow postnotes to send control to next note match when postnotes + next note match have the same start notes #2341

Open ThePotatoGuy opened 6 years ago

ThePotatoGuy commented 6 years ago

Way to mitigate #2340

Playing postnote phrases are optional, but since they both start with "o" in your reality, the state machine assumes users are trying to play postnote phrases and can eat the start of next line. we should have some sort of way to go to the next note match if we detect that the postnote match fails but the next note match works.

ThePotatoGuy commented 6 years ago

just an fyi to anyone who actually looks at this issue, this is significantly more complicated than it seems.

Main issue is if the next note match has a lyric, it would appear that there is a delay in between starting the note matches and when it gets considered a note match / post note match.

for example:

The post note phrase starts out like: opo opo ]

while the next note phrase is: opo uio

The earliest the system can transfer control is at the 4th note, when u is hit instead of o. Monika would appear to miss the first 3 words in teh 2nd verse.

So some thoughts:

The osu mania option wouild be ideal, but that is certainly not happening anytime soon. Maybe on the anniversary of the piano?

ThePotatoGuy commented 5 years ago

[closing until we look into it]