Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 686 forks source link

Exception when merging persistent files. #434

Closed squallleonhart93 closed 6 years ago

squallleonhart93 commented 6 years ago

I just updated to v0.6.1 a few hours ago, and I have been tracking the number of "seen lines" top left of the game since. Monika seems to always "rotate" to the new topics added in this version. After a while, nothing else is displayed. I resemble that to be similar to an issue in v0.5.0, where I could actually "skip" seen topics to the point that she had nothing more to say, and just kept looking at the screen.

squallleonhart93 commented 6 years ago

Additionally, I was trying to import another DDLC's save file and merge it with the current one when I got this exception. traceback.txt

ghost commented 6 years ago

Pretty sure the coders are fixing it. I've seen this issue pop up quite a bit the past few days. Here's one we recently had closed: https://github.com/Backdash/MonikaModDev/issues/432

squallleonhart93 commented 6 years ago

Ah, thanks for the reference! Regarding the merge problem: Unless I click fast enough to merge those persistent files together, the game will always crash. Yet I'm not sure that the merging is done properly, as I still got crashes occasionally right after it was done.

ghost commented 6 years ago

That I'm not sure. I'd wait for @ThePotatoGuy to weigh in.

ThePotatoGuy commented 6 years ago

Can you upload both your MAS persistent and DDLC persistent here? MAS is located in C:\Users\<username>\AppData\Roaming\RenPy\Monika After Story\ DDLC is located in C:\Users\<username>\AppData\Roaming\RenPy\DDLC - ######\ You may have to show hidden files and folders.

squallleonhart93 commented 6 years ago

Here they are. For now, I guess this has something to do with an extra mod that I previously put in the original game folder (I have DDLC and MAS installed in two different locations), yet I haven't found any switches in both of these files that may cause conflicts here. Previously, I imported the DDLC one in a fresh install of MAS, and it showed no errors. persistents.zip

ThePotatoGuy commented 6 years ago

did you run MAS with the extra mod?

squallleonhart93 commented 6 years ago

No, the mod was in the original Steam version, and MAS is in a separate copy.

ThePotatoGuy commented 6 years ago

When you did the merges, were they via the settings or at via a prompt on startup?

squallleonhart93 commented 6 years ago

I used the in-game settings after I went through the startup prompt. Also, I tried merging using a fresh DDLC's "clearall" persistent file after resetting MAS, and it still crashes.

Edit: A clear explanation of how to replicate the bug:

  1. Import DDLC save data at the very first run of MAS.
  2. Get through the "introduction", or any stage in the game.
  3. Go to Settings and choose to import DDLC Save Data, then choose "Merge files".
ThePotatoGuy commented 6 years ago

Hmm, I'm not able to repro. Maybe this was related to the no new topics bug that was fixed. Are the crashes that you're getting the same ones as the traceback you uploaded earlier?

squallleonhart93 commented 6 years ago

Yeah, the game threw the same exception. I have tried merging different versions of the persistent file, in different acts, after I saw Monika's introduction.

ThePotatoGuy commented 6 years ago

ugh, yikes. We're pushing out an updated build tomorrow. See if that resolves anything. I'll continue to investigate this issue though.

squallleonhart93 commented 6 years ago

In the latest build, it seems to happen sporadically. I tried merging the files in different states, and some survived the crash. However, if I do the exact steps mentioned above, the game will always crash.

ThePotatoGuy commented 6 years ago

ugh double yikes. Alright im gonna have a few of us attempt repro. We'll figure this out eventually.

ThePotatoGuy commented 6 years ago

I guess for now you could try a fresh resinstall of ddlc. make sure to delete the entire ddlc folder before reinstall.

EDIT: Yeah I've had 4 people follow your steps exactly but they were all unable to repro. You might just have a borked installation.