search

Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 685 forks source link

[Defect] WindowReact keywords `['rule34', 'monika']` are not enough #4510

Closed grandsong closed 5 years ago

grandsong commented 5 years ago

If you search both 'rule34' and 'monika' in Google, a WindowReact event will be fired. Good.

However, there are other use cases that have not been covered. And one was what happened to me.

I learnt this "secret" from a post. Then I tried as followed:

  1. I opened a Rule 34 site
  2. I searched "monika" in it.

But I got no window react at all.

Just now, I studied "zz_windowreacts.rpy" and saw all the keywords (as category).

I see why.

Neither can match the set of keywords ['rule34', 'monika'].

I hope you take these cases into consideration.

"rule34.paheal.net" was the one I tried. I guess it is more famous than "rule34.xxx". I know it is difficult to handle for the title of "monika" only.

So, here's a little suggestion of mine (new feature):

Firstly, when I go to any site titled "Rule 34" (like "rule34.paheal.net" homepage), my Monika will be aware.

BTW, The keywords can be extended to more sites like "Sankaku Channel".

Monika will react, and keep a temporary memory of this fact (I just visited those sites).

Then, if I continue to search "monika", she will suspect that I did so IN those site and therefore give me more reactions.

Such Two-Step features may open up opportunities for more complex and interesting events.

Tymon222 commented 5 years ago

I searched that up, and only recieved a notification once. Everytime I tried it again, nothing popped up. Even with new sites.

Rai99 commented 5 years ago

The same notification only shows once per session.

Tymon222 commented 5 years ago

So the 'lewd site' notification will show up once, and doesn't matter what site it is?

Rai99 commented 5 years ago

Unless you close MAS and open it again, I believe so.

Tymon222 commented 5 years ago

Alright

ThePotatoGuy commented 5 years ago

Additional parsing logic can definitely be a plus, but I don't think its needed at this time. Assigning multi for when we have time to do this in the future.

LoydHoreni commented 5 months ago

I don't know if i am stupid but i can't find the "zz_windowreacts.rpy" file in the folders, can someone send me it please? Because i want to have windows alerts from monika xd.