Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.21k stars 684 forks source link

[Bug] - Piano memory leak #5011

Open Booplicate opened 5 years ago

Booplicate commented 5 years ago

I got a traceback several days ago

I'm sorry, but an uncaught exception occurred.

While loading <'Image' u'mod_assets/monika/c/multimokia_jacket_white/arms-leaning-def-right-def-1-n.png'>:
error: Out of memory

I had piano opened for like 3 hours maybe even more. I tried to reproduce the bug again with the task manager and found the leak. I left the game opened for an hour with piano. Nothing more, just MAS (not minimized, windowed, with animations). There is RAM usage for MAS over time with opened piano.

Before opening the minigame - 380
T+0 - 400
T+5 - 450
T+10 - 530
T+15 - 580
T+20 - 630
T+30 - 670
T+40 - 760
T+50 - 850
T+60 - 930
After closing the minigame - 1160
In about 5 mins RAM usage is back to 380 mb

Tested twice on different PC (with 12 and 8 total RAM).

ThePotatoGuy commented 5 years ago

leaving open for investigation

kkrosie123 commented 4 years ago

Yes, I had this same bug a while back. #4585

Booplicate commented 2 years ago

This is a bug (probably only for old versions of renpy) where during interaction renpy will memory leak. The only way to fix it is by calling renpy.restart_interaction. We should aim to upgrade our version to fix this.