search

Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.18k stars 685 forks source link

v0.12.8 typos #8683

Closed ThePotatoGuy closed 2 years ago

ThePotatoGuy commented 2 years ago

FB_IMG_1643706926191

Ulti70895 commented 2 years ago

image It should be followed by a noun (is thinking..)?

multimokia commented 2 years ago

In this context, you is the noun.

MrVavlo commented 2 years ago

FIXED

Line 17834 in script-topics.rpy: there's missed comma in this line before "ahaha".

m 4rksdlb "It was one of the strangest things I've ever tasted ahaha!"

P.S don't tell me I've posted in the wrong place again aaa

Justformas commented 2 years ago

FIXED

I noticed the topics in this mod spell "traveling" with two letter L's so it's "travelling" while it spells "travel" with one L. It is an alternate spelling. From Grammarly.com "Traveling is the preferred spelling in the U.S. Travelling is the preferred spelling in the UK or in the Commonwealth." But Grammarist.com outright says "In American English, the inflected forms of travel take one l"

Admittedly some things in this game do seem to make me think of the UK, but is this mod going with UK spelling, or US spelling? Because I noticed #8991 and https://github.com/Monika-After-Story/MonikaModDev/issues/8991#issuecomment-1073057371

Our mod uses American English, not UK English.

NOT A TYPO

Another thing that I'm guessing is intentional, but just to make sure: "Witch story do you want to hear?" when selecting a scary story to hear. A sort of pun I guess, but yes I think it's fitting.

SOUNDS LESS FORMAL, LEAVING FOR NOW

Edit: I think I found something here in the monika_bullying topic:

Line 11072 in script-topics.rpy

m 2eksdlc "But I will admit I can relate to the part about bullies being unhappy and that it causes them do what they do."

Shouldn't it be "causes them to do" not "causes them do"?

Justformas commented 2 years ago

NOT A TYPO

Another one, in monika_mystery

Line 13447 m 1eua "It's almost funny...knowing the answers actually changes how you view the story itself."

"the answers actually changes"

It should either be "the answer actually changes how" or "the answers actually change how". I think it's the former, considering this line is referring to one story and the previous line is referring to one twist: "Knowing a twist can really alter how someone views an entire narrative. Not many plot points can do that!"

By the way, I am actually finding and noticing these just by playing the mod. I then find them in the code to confirm and reference here.

Justformas commented 2 years ago

Oh and "traveller"? That's used in several lines too.

NOT A TYPO

Another one, in monika_mystery

Line 13447 m 1eua "It's almost funny...knowing the answers actually changes how you view the story itself."

Edited: Nevermind about that then. Just got confused with "answers" and "changes".

kkrosie123 commented 2 years ago

I agree with Justformas here - take it from the grammar-obsessed nerd.

Justformas commented 2 years ago

I agree with Justformas here - take it from the grammar-obsessed nerd.

Maybe I'm obsessed but I wouldn't call myself a grammar expert. Or did you mean you and not me?

kkrosie123 commented 2 years ago

I mean myself, sorry for the lack of clarity, haha.

Booplicate commented 2 years ago

Answers don't change anything themselves. Knowing the answers changes. Knowing changes.

kkrosie123 commented 2 years ago

Ah, I see. Two ways to read that line. I guess it just gets confusing.

Justformas commented 2 years ago

Actually yeah I just realized something didn't seem right with what I thought. The original noun is "knowing" so that's technically correct (the best kind of correct) Just might look weird if you look at it a certain way. kkrosie123 hit the nail on the head.

By the way don't think I've found any other typos.

kkrosie123 commented 2 years ago

Perhaps we should rephrase the line to avoid confusion.

Justformas commented 2 years ago

Ok I have to ask what is this whole "tom" thing? Is that a joke about Tom Clancy or this? https://www.reddit.com/r/DDLC/comments/7rhrdd/tom_clancys_doki_doki_literature_club/ because I don't even know what that's about. Like I said before I am sort of under a rock when it comes to that sort of stuff.

Edited: Ok I saw that kkrosie123, thanks.

kkrosie123 commented 2 years ago

Tom is the creator of RenPy.

Wingdinggaster656 commented 2 years ago

script-fun-facts.rpy, line 492:

Naturally it differs from person to person but but reading slowly like we're taught is usually less effective than going at at a faster pace. I think there is one extra at.

EDIT: Oh well it might be not. Since we have this following line: For example, in this sentence, by the the time you are done reading you will have already skipped over the double 'the.' These two ats may also be on purpose. ...Maybe we should leave a comment in the code to stress that this isn't a typo?

Booplicate commented 2 years ago

It's what she's talking about in the fun fact itself, there's double at, but, and the.

Justformas commented 2 years ago

I think I just noticed a minor one, and found where it is in pong.rpy line 739 "I wouldn't want you get upset over a game, after all."

Should be "you getting upset" or "you to get upset" right?

Oh and:

SOUNDS LESS FORMAL, LEAVING FOR NOW

Edit: I think I found something here in the monika_bullying topic:

Line 11072 in script-topics.rpy

m 2eksdlc "But I will admit I can relate to the part about bullies being unhappy and that it causes them do what they do."

Possible idea then: change to "makes them do what they do."

ThePotatoGuy commented 2 years ago

[closing as fixed]