Monika-After-Story / MonikaModDev

DDLC fan mod to extend Monika
http://www.monikaafterstory.com/
Other
1.19k stars 685 forks source link

v0.12.13 + v0.12.14 typos #9800

Closed ThePotatoGuy closed 1 year ago

ThePotatoGuy commented 1 year ago

syuen_burning

DUBS GET

Wingdinggaster656 commented 1 year ago

script-story-events.rpy, line 553:

                m 1ttu "Are you sure this is your real name, or are you messing with me?{nw}"
                $ _history_list.pop()
                menu:
                    m "Are you sure this is your real name, or are you messing with me?{fast}"

                    "Yes, this is my name":
                        $ persistent._mas_disable_eggs = True

                    "Maybe...":
                        $ persistent._mas_disable_eggs = False

We are missing a period in the Yes, this is my name option.

Booplicate commented 1 year ago

In mas_f14_monika_vday_chocolates: "Not only is it the anniversary of my twitter account, but it's also a day for receiving and giving chocolates!" The phrase my twitter account is a controversy with:

"Did you know there's an official Twitter account based on me?"
"The username is {a=https://twitter.com/[mas_monika_twitter_handle]}{i}{u}[mas_monika_twitter_handle]{/u}{/i}{/a}."
"...Though, I'm not entirely sure who's actually running the account.{w=0.2} {nw}"
"I don't have anything to do with it at all!"
"But is it even another Monika?"
Wingdinggaster656 commented 1 year ago

script-greetings.rpy, label greeting_back from_work:

        m 2ekc "If you don't mind talking about it, what happened today?{nw}"
        #Since this menu is too long, we'll use a gen-scrollable instead
        python:
            final_item = ("I don't want to talk about it.", False, False, False, 20)
            menu_items = [
                ("I got yelled at.", ".yelled_at", False, False),
                ("I got passed over for someone else.", ".passed_over", False, False),
                ("I had to work late.", ".work_late", False, False),
                ("I didn't get much done today.", ".little_done", False, False),
                ("Just another bad day.", ".bad_day", False, False),
                ("I felt sick today.", ".sick", False, False),
            ]

        show monika 2ekc at t21
        $ renpy.say(m, "If you don't mind talking about it, what happened today?{fast}", interact=False)
        call screen mas_gen_scrollable_menu(menu_items, mas_ui.SCROLLABLE_MENU_TXT_MEDIUM_AREA, mas_ui.SCROLLABLE_MENU_XALIGN, final_item)

We showed the sentence twice, and we didn't put a _history_list.pop() between them.

By the way, MAS used nointeract in greeting_back_from_school instead of showing the sentence twice, we probably should keep the coding style consistent as well.

Wingdinggaster656 commented 1 year ago

label monika_snow:

    m "Does it ever snow where you live?{nw}"
    $ _history_list.pop()
    menu:
        m "Does it ever snow where you live?{fast}"

        "Yes":
            $ persistent._mas_pm_gets_snow = True

            m 1hub "That's wonderful!"
            m 1eua "I've always liked the peaceful aura it seems to give off."
            m 1dsa "It's just so tranquil and intimate, you know?"
            m 1hua "There's a quiet beauty in watching a soft, white blanket of snow and ice tuck the world away to sleep."
            call monika_snow_gets_snow

        "No":
            $ persistent._mas_pm_gets_snow = False

            call monika_hemispheres_nogets_snow

Both the Yes and No options do not have a period at the end.

Wingdinggaster656 commented 1 year ago
label monika_happiness:

    m 1eua "[player], are you happy?"
    m "With your life in general, I mean."
    m 2lksdla "It's okay if you aren't. I can understand you being unhappy, [player]."
    m 1eka "After all, without you, my life would be completely unbearable."
    m 1eua "Isn't it funny that we're able to suffer more than be happy?"

This is not a real problem, but this empty line always makes me a little uncomfortable.

Wingdinggaster656 commented 1 year ago
label mas_bday_spent_time_with:
    if mas_isMoniUpset(lower=True):
        m 1eka "[player]..."
        m 3eka "I just wanted to say I really appreciate you spending time with me today."
        m 3rksdla "I know it hasn't been going that great lately, but you taking the time to celebrate my birthday with me..."
        m 1eud "Well it gives me hope that maybe it's not too late for us."
        m "Perhaps today can be the start of something really special.."
        m 3eka "That would be the be the best gift I could ever ask for."

The Perhaps today can be the start of something really special.. line missed a ..

Booplicate commented 1 year ago

10038