MonkAlex / MangaReader

Help to download updates from online manga readers.
http://monkalex.github.io/MangaReader/
MIT License
50 stars 6 forks source link

Async await in all async API #132

Closed MonkAlex closed 5 years ago

MonkAlex commented 5 years ago

Fixed #126

MonkAlex commented 5 years ago

Mangachan tests require login now, see #127

codecov[bot] commented 5 years ago

Codecov Report

Merging #132 into master will decrease coverage by 2.52%. The diff coverage is 28.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   70.92%   68.39%   -2.53%     
==========================================
  Files         175      174       -1     
  Lines        6555     6525      -30     
  Branches      533     1111     +578     
==========================================
- Hits         4649     4463     -186     
+ Misses       1672     1633      -39     
- Partials      234      429     +195
Impacted Files Coverage Δ
MangaReader.Core/ISiteParser.cs 100% <ø> (ø) :arrow_up:
MangaReader.Core/Entity/Entity.cs 61.9% <ø> (ø) :arrow_up:
MangaReader.Core/Manga/MangaHistory.cs 56% <ø> (-8%) :arrow_down:
Tests/Tests.Entities/Manga/ReadmangaMoved.cs 86.36% <0%> (-4.55%) :arrow_down:
Tests/Tests.Entities/Manga/HentaichanStructure.cs 72.72% <0%> (-25.76%) :arrow_down:
Sites/Hentaichan.me/HentaichanLogin.cs 7.84% <0%> (-0.16%) :arrow_down:
Sites/Hentaichan.me/BaseLogin.cs 41.81% <0%> (ø) :arrow_up:
Sites/Hentaichan.me/Mangachan/Mangachan.cs 38.7% <0%> (-2.47%) :arrow_down:
Sites/Acomics.ru/Acomics.cs 50% <0%> (-2.64%) :arrow_down:
Tests/Tests.Entities/Library/Update.cs 81.81% <0%> (-10.91%) :arrow_down:
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a5f105...07afc46. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #132 into master will decrease coverage by 6.55%. The diff coverage is 17.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   70.92%   64.36%   -6.56%     
==========================================
  Files         175      173       -2     
  Lines        6555     6444     -111     
  Branches      533     1379     +846     
==========================================
- Hits         4649     4148     -501     
+ Misses       1672     1577      -95     
- Partials      234      719     +485
Impacted Files Coverage Δ
MangaReader.Core/BasePlugin.cs 100% <ø> (ø) :arrow_up:
MangaReader.Core/ISiteParser.cs 100% <ø> (ø) :arrow_up:
MangaReader.Core/Manga/MangaHistory.cs 66.66% <ø> (+2.66%) :arrow_up:
MangaReader.Core/NHibernate/Repository.cs 100% <ø> (ø) :arrow_up:
MangaReader.Core/Manga/MangaName.cs 65.51% <ø> (+19%) :arrow_up:
MangaReader.Core/Services/DownloadManager.cs 73.17% <0%> (-4.88%) :arrow_down:
Tests/Tests.Entities/CRUD/MangaHistory.cs 65.21% <0%> (-34.79%) :arrow_down:
MangaReader.Core/Convertation/Config/From43To44.cs 57.89% <0%> (-31.58%) :arrow_down:
Tests/Tests.Entities/Manga/ReadmangaCensored.cs 70.96% <0%> (-25.81%) :arrow_down:
Tests/Tests.Entities/Library/Update.cs 67.27% <0%> (-25.46%) :arrow_down:
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a5f105...29f09bf. Read the comment docs.

MonkAlex commented 5 years ago

So, main part of work completed. Now need test #126 and maybe rescan code with foreach (...) await some