search

MonkeScripts / pe

0 stars 0 forks source link

Integer overflow, quantity is a whole number but not regarded as one #8

Open MonkeScripts opened 2 months ago

MonkeScripts commented 2 months ago

image.png

nus-se-bot commented 2 months ago

Team's Response

Duplicate of #854.

Again, I'm not sure what you mean by integer overflow. There is no proof of any integer overflow as your input was rejected in the first place.

Yes, the quantity that you've tried to input is a whole number. But it's too large to even be considered as a valid value by our application! Thus, our application correctly invalidates your input.

Lastly, just to reiterate the same point I've raised in your previous bug reports - this is obviously proof of extreme user behaviour. image.png

In this case, we have the right to say that this is an invalid bug report.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Integer overflow for all whole number outputs

image.png

[original: nus-cs2113-AY2324S2/pe-interim#777] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Clearly an example of extreme user behavior. Noted on the attempts to try some sort of input injection attacks as well 🙄.

image.png

Anyway, there is obviously no integer overflow in this case. The extremely large threshold value, which you tried to input, was correctly caught by the application and treated as invalid.

How can you therefore say that there is an overflow when your input has been invalidated and not accepted by the application?

High bug severity is completely unjustified and unwarranted as well, since there is no concrete proof of "integer overflow" in your attached screenshot. I'll reduce its severity to Low.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Integer overflow refers to input of large integers like 999999999999999999. These large integers are indeed whole numbers and therefore error messages printed out is erroneous.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]