Monkestation / MonkeStation

Return to monkestation
https://discord.com/invite/monkestation
GNU Affero General Public License v3.0
15 stars 47 forks source link

Emergency Shuttle Emag Rebalance #982

Open lmenvs opened 1 year ago

lmenvs commented 1 year ago

About The Pull Request

Reworks shuttle emagging so that instead of it reducing the time left to 10 seconds, it will halve the remaining time each usage. You can keep halving the remaining time until it has reached 10 seconds, the emag effect has a 2 second cooldown.

While reworking this I also noticed that hijacking was not working as intended; there was supposed to be a cooldown between attempts at increasing hijack stages, but was not implemented correctly. While this does fix that, I feel that 5 seconds may be too big of a nerf from being able to spam it, so as a slight compromise, it'll be 2 seconds, just like the emag.

I'd be happy to adjust these numbers for balance reasons as well.

closes https://github.com/Monkestation/MonkeStation/issues/247

Why It's Good For The Game

This was requested by Zanden a while ago, and while emags are a great and powerful traitor item, a single silly click of a button probably shouldn't have such a powerful effect on the emergency shuttle.

Testing Photographs and Procedure

Screenshots&Videos Put screenshots and videos here with an empty line between the screenshots and the `
` tags.

Changelog

:cl:

balance: Emagging the emergency shuttle now halves remaining timer. You can further reduce the timer by using the emag again (every 2 seconds). fix: Hijacking stage increases now properly have a cooldown (2 seconds). /:cl:

etherware-novice commented 1 year ago

hey thanks for using my idea