Monkestation / Monkestation2.0

A monkestation rebase to TG code
https://monkestation.com/
GNU Affero General Public License v3.0
44 stars 223 forks source link

IPCs are held together by errors #1583

Closed MonkestationIssueBot closed 5 months ago

MonkestationIssueBot commented 6 months ago

Reporting client info: Client Information: BYOND:515.1630 Key:milkforever

Round ID:

4447

Testmerges:

Reproduction:

Chopping off an IPC's head or limb will make the wound flavor text say "Errors" Instead of "Flesh" holding it together. Example: IPC's head is shattered through the last error holding it together, severing it completely!

LikeLakers2 commented 6 months ago

I saw this issue and, while I don't plan to work on monkestation for the foreseeable future, I feel I could at least look into why this is happening.

Some searches for the text "error" lead me to /obj/item/bodypart/proc/get_external_description() and /obj/item/bodypart/proc/get_internal_description():

https://github.com/Monkestation/Monkestation2.0/blob/5c765c12434333bb8f5582552e5122f6843e4391/code/modules/surgery/bodyparts/_bodyparts.dm#L1292-L1308

which is not overridden by any of the IPC body parts at https://github.com/Monkestation/Monkestation2.0/blob/5c765c12434333bb8f5582552e5122f6843e4391/monkestation/code/modules/surgery/bodyparts/ipc_bodyparts.dm.

I have not personally verified if overriding those procs on the IPC body parts would solve the issue - but I do hope it'll help whoever decides to fix this issue regardless.