Monkestation / Monkestation2.0

A monkestation rebase to TG code
https://monkestation.com/
GNU Affero General Public License v3.0
44 stars 229 forks source link

Xeno Queens are deleted on use with bluespace body bags #1631

Open MonkestationIssueBot opened 6 months ago

MonkestationIssueBot commented 6 months ago

Reporting client info: Client Information: BYOND:515.1634 Key:dexee

Round ID:

4520

Testmerges:

Reproduction:

1) acquire PLAYER xeno queen 2) xeno queen rests 3) bluespace bodybag. zip up. 4) pick up the bag 5) place the bag down again 6) open bag. xeno queen is DELETED.

[09:34:02] Runtime in code/game/objects/structures/crates_lockers/closets/bodybag.dm, line 161: Cannot execute null.get mutation(). proc name: perform fold (/obj/structure/closet/body_bag/bluespace/perform_fold) usr: Joe Mona/(Goliath Rattos) usr.loc: (Genetics Lab (145,101,2)) src: the bluespace body bag (/obj/structure/closet/body_bag/bluespace) src.loc: the plating (144,100,2) (/turf/open/floor/plating) call stack: the bluespace body bag (/obj/structure/closet/body_bag/bluespace): perform fold(Goliath Rattos (/mob/living/carbon/human)) the bluespace body bag (/obj/structure/closet/body_bag/bluespace): attack hand secondary(Goliath Rattos (/mob/living/carbon/human), null) Goliath Rattos (/mob/living/carbon/human): resolve right click attack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), null) Goliath Rattos (/mob/living/carbon/human): right click attack chain(the bluespace body bag (/obj/structure/closet/body_bag/bluespace)) Goliath Rattos (/mob/living/carbon/human): UnarmedAttack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), 1) Goliath Rattos (/mob/living/carbon/human): ClickOn(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), "icon-x=20;icon-y=10;right=1;bu...") the bluespace body bag (/obj/structure/closet/body_bag/bluespace): Click(the plating (144,100,2) (/turf/open/floor/plating), "mapwindow.map", "icon-x=20;icon-y=10;right=1;bu...") the bluespace body bag (/obj/structure/closet/body_bag/bluespace): Click(the plating (144,100,2) (/turf/open/floor/plating), "mapwindow.map", "icon-x=20;icon-y=10;right=1;bu...") /datum/callback/verb_callback (/datum/callback/verb_callback): Invoke() world: push usr(Goliath Rattos (/mob/living/carbon/human), /datum/callback/verb_callback (/datum/callback/verb_callback)) /datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync() Input (/datum/controller/subsystem/verb_manager/input): run verb queue() Input (/datum/controller/subsystem/verb_manager/input): fire(0) Input (/datum/controller/subsystem/verb_manager/input): fire(0) Input (/datum/controller/subsystem/verb_manager/input): fire(0) Input (/datum/controller/subsystem/verb_manager/input): ignite(0) Master (/datum/controller/master): RunQueue() Master (/datum/controller/master): Loop(2) Master (/datum/controller/master): StartProcessing(0)

DexeeXI commented 6 months ago

[09:34:02] Runtime in code/game/atoms_movable.dm, line 1093: No valid destination passed into forceMove proc name: forceMove (/atom/movable/proc/forceMove) usr: Joe Mona/(Goliath Rattos) usr.loc: (Genetics Lab (145,101,2)) src: the alien queen (242) (Rattos ... (/mob/living/carbon/alien/adult/royal/queen) src.loc: the bluespace body bag (/obj/item/bodybag/bluespace) call stack: the alien queen (242) (Rattos ... (/mob/living/carbon/alien/adult/royal/queen): forceMove(null) the alien queen (242) (Rattos ... (/mob/living/carbon/alien/adult/royal/queen): forceMove(null) the bluespace body bag (/obj/item/bodybag/bluespace): Destroy(0) qdel(the bluespace body bag (/obj/item/bodybag/bluespace), 0) the bluespace body bag (/obj/structure/closet/body_bag/bluespace): Destroy(0) qdel(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), 0) the bluespace body bag (/obj/structure/closet/body_bag/bluespace): attack hand secondary(Goliath Rattos (/mob/living/carbon/human), null) Goliath Rattos (/mob/living/carbon/human): resolve right click attack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), null) Goliath Rattos (/mob/living/carbon/human): right click attack chain(the bluespace body bag (/obj/structure/closet/body_bag/bluespace)) Goliath Rattos (/mob/living/carbon/human): UnarmedAttack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), 1) ... /datum/callback/verb_callback (/datum/callback/verb_callback): Invoke() world: push usr(Goliath Rattos (/mob/living/carbon/human), /datum/callback/verb_callback (/datum/callback/verb_callback)) /datum/callback/verb_callback (/datum/callback/verb_callback): InvokeAsync() Input (/datum/controller/subsystem/verb_manager/input): run verb queue() Input (/datum/controller/subsystem/verb_manager/input): fire(0) Input (/datum/controller/subsystem/verb_manager/input): fire(0) Input (/datum/controller/subsystem/verb_manager/input): fire(0) Master (/datum/controller/master): RunQueue() Master (/datum/controller/master): StartProcessing(0)

DexeeXI commented 2 months ago

proc name: forceMove (/atom/movable/proc/forceMove) usr: Dexee/(Mentor Maid) usr.loc: (CentCom Administrative Office (121,39,1)) src: the alien queen (/mob/living/carbon/alien/adult/nova/queen) src.loc: the bluespace body bag (/obj/item/bodybag/bluespace) call stack: the alien queen (/mob/living/carbon/alien/adult/nova/queen): forceMove(null) the alien queen (/mob/living/carbon/alien/adult/nova/queen): forceMove(null) the bluespace body bag (/obj/item/bodybag/bluespace): Destroy(0) qdel(the bluespace body bag (/obj/item/bodybag/bluespace), 0) the bluespace body bag (/obj/structure/closet/body_bag/bluespace): Destroy(0) qdel(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), 0) the bluespace body bag (/obj/structure/closet/body_bag/bluespace): attack hand secondary(Mentor Maid (/mob/living/carbon/human), null) Mentor Maid (/mob/living/carbon/human): resolve right click attack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), null) Mentor Maid (/mob/living/carbon/human): right click attack chain(the bluespace body bag (/obj/structure/closet/body_bag/bluespace)) Mentor Maid (/mob/living/carbon/human): UnarmedAttack(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), 1, /list (/list)) Mentor Maid (/mob/living/carbon/human): ClickOn(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), "icon-x=20;icon-y=9;right=1;but...") the bluespace body bag (/obj/structure/closet/body_bag/bluespace): Click(the floor (122,38,1) (/turf/open/floor/wood/large), "mapwindow.map", "icon-x=20;icon-y=9;right=1;but...") Dexee (/client): Click(the bluespace body bag (/obj/structure/closet/body_bag/bluespace), the floor (122,38,1) (/turf/open/floor/wood/large), "mapwindow.map", "icon-x=20;icon-y=9;right=1;but...")

reconfirmed as fuck except skip the part of dropping the bag back down as the BAG IS QDEL'D.

also deletes xeno drones. This is bad.

This is an exploit. Anyone that uses this will be permanently b&.