search

Monkestation / Monkestation2.0

A monkestation rebase to TG code
https://www.monkestation.com
GNU Affero General Public License v3.0
43 stars 206 forks source link

As chaplain to the honorbound god if you drink with a helmet on you commit an unforgivable offence #3160

Open restedwaves opened 1 month ago

restedwaves commented 1 month ago

Round ID:

Testmerges:

Round ID: 6556 BYOND Version: 515.1642 Server revision compiled on: 2024-08-27T23:22:34+00:00 Master commit: 13be643750a654bd3e7ee53719e17acefede5d35 The following pull requests are currently test merged: #2766: 'Ore Processing Framework' by dwasint at commit ebc5a94545 #2850: '[Fully-Modular] Adds a keybind to allow for pixel shifting of one's character, and items they are grabbing' by Odairu at commit d7298af850 #2915: 'Scrubber overflows now use liquids' by Absolucy at commit 7e44f13a97 #2945: 'Event Groups: morbillion anomalies begone!' by Absolucy at commit 599785aa96 #3025: 'The Forge Update' by V2LenKagamine at commit 7228e386ce #3092: 'Revert "Optimize replays by implementing batch marking"' by dwasint at commit c85f8af662 #1177: 'Exosuit UI Update + Equipment Refactor' by SapphicOverload at commit 1f6f9d276d #2306: '[PORT] Removes unnecessary list of components with /datum/component as its key from /datum's _datum_components' by LikeLakers2 at commit bd0ac762ef #3114: '[Bounty] The Arti-Re-Factoring Base' by V2LenKagamine at commit 551647659a #2872: 'Mail Tokens, Smoking Pipe Adjustment/Fixes, and Tobacco Grudge Code' by SirNightKnight at commit 7ac530611d #3139: 'Theseus ' by t-toasted at commit e80daf9d69 #2709: 'Adds more PTL milestone messages, removes history rolls, adds 1 more magnitude to the PTL' by Gboster-0 at commit 1ead341063

Local commit: 5f3dae5cf657ce531569164c7cdabb93e7824d64 TGS version: 6.1.5 DMAPI version: 5.9.0

Current Informational Settings: Protect Authority Roles From Traitor: 1 Protect Assistant Role From Traitor: 0 Enforce Human Authority: 0 Allow Latejoin Antagonists: 1

Reproduction:

pledge to the honorbound god try drinking, (I tried from a bottle) It seems to register it as you attacking an innocent get considered no longer innocent Be unable to forgive yourself (literally, the rite wont work) Screenshot 2024-08-27 205122 and yes i am lucy

Ideally I wouldnt be considered guilty for attacking myself, generally I would be displeased for attempting to drink through my helmet then getting considered guilty for doing so. so i think that should be fixed.

Supermichael777 commented 1 month ago

The item is failing to cancel the attack chain.