Monkestation / Monkestation2.0

A monkestation rebase to TG code
https://www.monkestation.com
GNU Affero General Public License v3.0
39 stars 195 forks source link

Compound Fracture Surgery Fails to Complete #601

Closed DexeeXI closed 9 months ago

DexeeXI commented 9 months ago

Round ID:

2603

Testmerges:

526 #545

Reproduction:

1) Get a test subject, give them a compound fracture (try the head first). 2) Conduct compound fracture surgery as normal (scalpel, retractor, hemostat, bonesetter, bone gel) 3) Final step of Bone Gel fails to successfully pass through, leaving the surgery stuck on that step. The surgery can still be cancelled via the drapes/cautery.

Additional information:

The surgical computer will reflect this strange status. The wound does not get cleared once the surgery is completed. This has been noticed as odd and unusual for the last several days by our wonderful Doctor Mime Main Simply Arturo, but they were otherwise able to use Cryogenics to still fix people as medical Cryogenics can clear anything. There is a possibility this is associated with the merges around 5-6 days ago from today, but will need time to dive into those merges to see if any changes in those had done anything regarding the surgery modules.

DexeeXI commented 9 months ago

No runtimes appear to had been associated with this issue during the round.

InvisibleTeammate commented 9 months ago

Adding onto this, the final surgery step is supposed to be completed with either bone gel or surgical tape. However, when attempting to apply bone gel, it skips over the surgery and attempts to do the 'quickfix' nonsurgical paramedic method. This is not supposed to happen; it's supposed to finish the surgery and instantly fix the compound fracture. Surgical tape, on the other hand, does not work at all, and just gives a notice that bone gel needs to be applied first, when that is only supposed to be for the paramedic method and not the surgery.

DexeeXI commented 9 months ago

Turns out it was 100% a TG fuckup. #630 has a commit to fix this issue.