search

MonkeyMaster64 / Reddit-User-Media-Downloader-Public

480 stars 42 forks source link

imagededup cloning? #3

Closed derwana closed 3 years ago

derwana commented 3 years ago

For the Linux Setup: why cloning imagededup, when it's already in the requirements.txt?

derwana commented 3 years ago

tested it, cloning is not necessary

derwana commented 3 years ago

4

dausruddin commented 3 years ago

On Python 3.9.5, it spits out errors for Pillow 1.7.7 down to 1.0.

image

Then errors from numpy 1.6.2 down to 1.3.0

image

Then after super long wait, imagededup refused to install

image

MonkeyMaster64 commented 3 years ago

Approved the commits

kdknigga commented 3 years ago

On Python 3.9.5, it spits out errors for Pillow 1.7.7 down to 1.0. ...

Yep, that's why I went with the newer imagededup that's not (yet?) in pypi.

yoshijulas commented 3 years ago

https://pillow.readthedocs.io/en/latest/installation.html#python-support

In python 3.9, Pillow only works version >= 8.0 and Imagededup requires <= 7

unless they update for the newer pillow, python 3.9 doesnt work

dausruddin commented 3 years ago

I'm wondering why @MonkeyMaster64 approved the commits without even considering.