Monnoroch / ColorHighlighter

ColorHighlighter - is a plugin for the Sublime text 2 and 3, which underlays selected hexadecimal colorcodes (like "#FFFFFF", "rgb(255,255,255)", "white", etc.) with their real color. Also, plugin adds color picker to easily modify colors. Documentation: https://monnoroch.github.io/ColorHighlighter.
https://sublime.wbond.net/packages/Color%20Highlighter
1.31k stars 130 forks source link

Better documentation of configuration settings, bugs, and a feature request #267

Open dougc84 opened 9 years ago

dougc84 commented 9 years ago

Hi - first off, great plugin. I love this thing.

After looking at the settings, I noticed a few things that don't have great documentation, and I want to request them to be added to the readme. Here's my list:

Also, a couple bugs I've found:

Finally, one last feature request. We currently have an application that is deployed on several different domains. Each domain gets its own "variable override" file to style each domain properly - different colors, font sizes, etc., but the overall experience is similar. Because of this, it would be really great to make the color_variables_file into color_variables_files and accept an array of files. It would also need to (if it doesn't already), at least in SASS/SCSS, understand the !default modifier on variables. I believe LESS has a similar keyword.

Thanks for the great plugin!

Monnoroch commented 9 years ago

Great suggestion, thanks! If you want to speed things up, this is an open source project and I am always open to contributions and I'd love, if you'd be willing to help me with those. But in any case, I'll dig into the problem as soon as I can.

Monnoroch commented 9 years ago

Have made color_variables_file into color_variables_files.

Monnoroch commented 9 years ago

About the default. It seems to me, that do do that type of thing you have to use a full-blown less/sass parsers, which would totally kill the performance.

Monnoroch commented 9 years ago

You can always look for options names in the menu files.

{
     "caption": "Colored text",
     "command": "ch_set_setting",
     "args": {"setting": "ha_style", "value": "text"}
},
Monnoroch commented 9 years ago

About color_variables_file(s) not working: I could not reproduce the bug. Seems fine to me. If you could test the new version and provide a minimal example to reproduce the bug I'd be grateful.

jacobbuck commented 9 years ago

@dougc84 I was getting a similar problem with color_variables_files, turns out it was because I was putting it in the wrong place:

{
  "folders": [
    {
      "color_variables_files": [...],
      ...

When it should've been in the root level:

{
  "color_variables_files": [...],
  "folders": [
    {    
      ...