search

MonoGame / MonoGame.Dependencies

The MonoGame binary dependencies submodule.
38 stars 51 forks source link

Updated SDL to 2.0.14 #151

Closed mrhelmut closed 3 years ago

mrhelmut commented 3 years ago

Hi there,

This is an update of SDL from 2.0.12 to 2.014

There are all built from source:

Tested working on all systems.

@harry-cpp @Jjagg

Jjagg commented 3 years ago

macOS built on High Sierra with clang (this one has a High Sierra requirement, which is the same as dotnet)

We currently still target .NET Framework with DesktopGL. Any idea if it's worth keeping support for older mac versions?

https://github.com/MonoGame/MonoGame/blob/5b040f6512c7acc79c7168f7df88ae6de4cb2529/MonoGame.Framework/MonoGame.Framework.DesktopGL.csproj#L4

<TargetFrameworks>netstandard2.0;net452</TargetFrameworks>

EDIT: looks like we already support only High Sierra and up according to our docs: https://docs.monogame.net/articles/platforms/0_platforms.html#desktopgl

mrhelmut commented 3 years ago

Let me check if I can work a backcompat with older macOS.

Jjagg commented 3 years ago

Not sure if you caught my edit. Our docs say we already have a High Sierra requirement, though I'm not sure what requires it.

mrhelmut commented 3 years ago

dotnet 3.1+ does, it's a runtime requirement. I guess I wrote that part, and didn't have net452 in mind for that.

The question is: do we expect users to not use dotnet on macOS and instead use the old MonoKickstart (which would support older macOS)?

Also, according to this site, High Sierra and above = ~90% of macOS users.

Jjagg commented 3 years ago

Deploying with MonoKickstart is a huge pain compared to the newer way. I wouldn't recommend it.

But 10% is quite a lot. I do think it'll be less than that for 'gamers', but the Steam survey does not help much because there's 7% unspecified OS version for macs: https://store.steampowered.com/hwsurvey?platform=mac.

Thoughts @harry-cpp @tomspilman?

harry-cpp commented 3 years ago

We should not support any macOS versions which have already reached their end of life (aka. anything lower than High Sierra already reached its end of life).

Jjagg commented 3 years ago

Ah, in that case I agree. We shouldn't go out of our way to support EOL versions. And we already covered this in our docs, so no changes required there :)

mrhelmut commented 3 years ago

Ready when you are then. I'll bump the dependencies as well as the SDL controller DB.