search

MonoGame / MonoGame.Dependencies

The MonoGame binary dependencies submodule.
38 stars 51 forks source link

Fix dylib mapping for OS X #87

Closed mrhelmut closed 8 years ago

mrhelmut commented 8 years ago

This is a small fix to the Mono dll mapping so that DesktopGL debugging works on OS X with the new SDL2 dependencies.

cc @KonajuGames

tomspilman commented 8 years ago

I'll leave this to @KonajuGames or @dellis1972 as I know nothing of this stuff. :)

dellis1972 commented 8 years ago

@mrhelmut done, we'll need a bump on the main repo now :)

KonajuGames commented 8 years ago

Shouldn't there be symlinks that link oalsoft.dylib to oalsoft.1.dylib and libSDL2.dylib to libSDL2-2.0.0.dylib? Isn't that how versioning is done in Linux and Mac land without having to change the filenames that applications reference?

mrhelmut commented 8 years ago

Since MG refers to specific dependencies which are shipped with MonoGame / MonoKickstart, I don't see any advantage in using symlinks (and that would make more files to add to the template), but I agree that there should be symlinks if it has to follow a clean Linux/Unix architecture.

@dellis1972 If you're fine with waiting, I'd like to leave the bump to @cra0zy, who most probably have a couple Eto updates in the work.

harry-cpp commented 8 years ago

I am with @KonajuGames on this, that way even if you don't include dependencies, as long as you install them manually the game will run. For Linux SDL should be named libSDL2.so and OpenAL should be named libopenal.so, don't know about the Mac namings tho.

@mrhelmut Do note that there aren't any symlinks on our side, we just need to change the names of sdl and openal libraries to match the default symlinks.

@dellis1972 If you're fine with waiting, I'd like to leave the bump to @cra0zy, who most probably have a couple Eto updates in the work.

There is https://github.com/mono/MonoGame/pull/4885 that needs to be merged before any other PR updates the dependencies.

dellis1972 commented 8 years ago

@mrhelmut @cra0zy @KonajuGames I merged this one did we want to revert? or are we going with the changes?

mrhelmut commented 8 years ago

I'm not a Unix user, it's up to you. :) Mind that if we go with symlinks, Linux should be modified too, as well as the templates.

harry-cpp commented 8 years ago

I'm not a Unix user, it's up to you. :) Mind that if we go with symlinks, Linux should be modified too, as well as the templates.

Again, we are not gonna have symlinks, we just need the libraries to have the same names as system symlinks.

mrhelmut commented 8 years ago

I get it. If that means that on OS X it would link to the Apple's implementation of OpenAL, note that it has inconsistencies with OpenAL-Soft.

KonajuGames commented 8 years ago

If that means that on OS X it would link to the Apple's implementation of OpenAL, note that it has inconsistencies with OpenAL-Soft.

That's not a good idea. I can hear the incoming issues now.