MonoLisaFont / feedback

Send us your feedback regarding the MonoLisa font
84 stars 2 forks source link

[Bug]: Regular looking Bold in VS Code #214

Closed dinhquochan closed 1 year ago

dinhquochan commented 1 year ago

Edition

Plus

What version are you using?

2.007

What type of weights are you using?

Default (non-customized)

Operating system

Windows 11

Program

VS Code

Display resolution

2560x1440

What happened?

Before 2.007, it's ok. I don't know why. I see the old issue #31 that tells me I should use TFF version, v2 is TFF already. I attach the screenshot, 1 JetBrains (left) 1 VS Code (right), Font 14px _ General, Turn off ligature:

image

bebraw commented 1 year ago

Can you add your VS Code configuration? Which weight are you using there?

dinhquochan commented 1 year ago

Yes, here:

{
    "editor.fontFamily": "MonoLisa",
    "editor.fontLigatures": false,
    "editor.fontSize": 14,
    "editor.fontWeight": "400"
}
bebraw commented 1 year ago

When using a number value, you should use "editor.fontWeight": 400,. You can also refer to weights by their name (i.e., "editor.fontWeight": "bold",).

dinhquochan commented 1 year ago

@bebraw It's ok before v2.007, not is string or number, you can see, I see from 100->500 is not affected, only 600 is bold, before it should be from light->regular->medium->bold. I will show you the old version.

image image image image

dinhquochan commented 1 year ago

Here is in v2.006 @bebraw

image image image image

bebraw commented 1 year ago

I tested this using Plus (2.007) on MacOS and scaling works perfectly there when using a number for fontWeight as instructed by VS Code.

You could also check with https://fontdrop.info/ and compare the files for 2.006 and 2.007.

I guess we would need someone using Windows to understand the issue better.

dinhquochan commented 1 year ago

Yes. On my Mac it is ok too. Only windows 🥲

bebraw commented 1 year ago

Ah, thanks for confirming. There's another Windows related issue so it feels like it's something coming from the build/api.

As an intermediate fix we might do a build through the old process. My gut feeling is that some Windows specific metadata might be off somehow.

bebraw commented 1 year ago

@dinhquochan We have a potential fix available now. Can you head to https://www.monolisa.dev/orders and choose prerelease before downloading and testing?

Screenshot 2023-05-12 at 12 28 38
dinhquochan commented 1 year ago

Hi @bebraw, it's fixed on pre-released.

image

bebraw commented 1 year ago

Published as 2.008. Thanks for the report.