MonoLisaFont / feedback

Send us your feedback regarding the MonoLisa font
84 stars 2 forks source link

[Bug]: Customizing v2.010 does not display Plus features #233

Closed siegblink closed 9 months ago

siegblink commented 9 months ago

Edition

Plus

What version are you using?

v2.010

What type of weights are you using?

Default (non-customized)

Operating system

macOS Sonoma 14.0

Program

VS Code

Display resolution

3456 x 2234

What happened?

I went to your website today to customize then download v2.010 but I noticed that "Plus features" that I want to include is not being displayed in the UI. Here's a screenshot:

image

If I check the playground page, the plus features are there.

image

Below are the selections I made then I downloaded it.

image

After installing the newly downloaded fonts, all the plus features I was hoping to get included are not there.

Not sure what's happening here or did I miss something?

bebraw commented 9 months ago

Note that the selections should freeze the features directly to the font files.

@okonet Could this be related to the recent changes?

bebraw commented 9 months ago

@siegblink Also note that you should not use the customize feature with VS Code since you can select the font features directly within it. Example: https://www.monolisa.dev/faq#how-to-enable-alternate-zero-stylistic-sets-and-the-script-variant .

bebraw commented 9 months ago

https://www.monolisa.dev/faq#what-are-the-suggested-settings has the suggested settings for VS Code.

siegblink commented 9 months ago

@bebraw I have no problem with VS Code, I'm good on that part.

I checked my Font Book app, the plus features such as the script variants and stuff are not there.

I reverted to v2.008 for now because v2.010 is broken for me.

okonet commented 9 months ago

Just to clarify: is the issue with the website or with the font?

bebraw commented 9 months ago

@siegblink You could try the following:

  1. Download the font without touching a single feature switch
  2. Open one of the downloaded ttfs at https://fontdrop.info/
  3. It should show all the features

I tried this with Plus and it showed the features thay were expected. If even a single switch is enabled, it won't include the extra features.

siegblink commented 9 months ago

@bebraw I followed your instructions.

Well, viewing newly downloaded MonoLisa font file without touching a single feature switch on fontdrop.info does display the plus features.

However, when you install the font file on your system, the issue still remains.

Thanks for the tip, though. But this is not the fix.

siegblink commented 9 months ago

@okonet I believe it's the website that's causing all of this.

bebraw commented 9 months ago

@siegblink Newly downloaded 2.010 works (no customization) works perfectly for me. To test, I tried toggling zero like this:

{
  "editor.fontFamily": "MonoLisa",
  "editor.fontWeight": 400,
  "editor.fontLigatures": "'zero' off",
}

I think we would need VS Code font configuration to reproduce the issue since Fontdrop worked for you.

siegblink commented 9 months ago

@bebraw I have no argument about MonoLisa v2.010 without customization. I have no trouble on this part.

What I'd really like to do is download v2.010 with customizations enabled and I don't know why I can't get those plus features.

Anyway, I'll roll back to v2.008 for now. I appreciate your help.

bebraw commented 9 months ago

@siegblink Ok, the customized version simply doesn't work with VS Code configuration since we strip the customized features and freeze them to the font.

It's possible there's some misunderstanding here and we don't know what to fix yet. Perhaps the UI could be more instructive as now the information is a bit hidden.

egaban commented 9 months ago

Same issue here. Everything worked fine in previous releases, now every variation is shown as the same symbol

image

bebraw commented 9 months ago

@egaban The UI should be fixed now.

egaban commented 9 months ago

It's working now, thanks :)

siegblink commented 9 months ago

Hey @bebraw

I just went to the website and I can see the UI is now fixed.

I customized my selection with the plus features that I want then download it.

After installing, the plus features are now showing up.

I even patched the whole thing with Nerd font and it's still working properly.

Thanks for fixing this problem. Cheers!