search

MonoLisaFont / feedback

Send us your feedback regarding the MonoLisa font
84 stars 2 forks source link

[Feature request]: `#{` ligature breaks bracket matching in VSCode #236

Closed martinemde closed 8 months ago

martinemde commented 8 months ago

What feature are you proposing?

The ligature #{ breaks VS Code bracket matching (where opening/closing brackets are colored the same.)

With ligatures:

Screenshot 2023-10-19 at 5 01 54 PM

Without:

Screenshot 2023-10-19 at 5 02 30 PM

What is interesting is that the editor isn't confused by it. It doesn't shift the colors over as if the ligature isn't an opening bracket. It just gets the coloring wrong.

I'm not sure this is fixable in the font, but at least I'd like to disable this specific ligature without losing every ligature. Is there a customization, maybe just in VS Code, that would allow this, or could I disable it in my version of the font somehow?

martinemde commented 8 months ago

You might also assume that the other #( and #[ would break matching as well, but I can't think of a language where that is not just a comment.

Also... I was a little disappointed by this. I just bought the font after using an older trial version. When I specifically checked the font in the playground, with ligatures on, this #{ ligature does not show up. I thought this meant it had been removed from the font because of bugs like this. I was disappointed to have this problem persist with the full Plus version.

martinemde commented 8 months ago

Ok. This is my fault. Sorry. I don't know where these ligatures were coming from, but it's not MonoLisa. I quit and reloaded VS Code because none of the font feature set tags were working. It fixed this bug as well.

Thank you and sorry for the confusion.