search

Monobjc / monobjc

Git Repository for the Monobjc Project
http://www.monobjc.net/
17 stars 3 forks source link

Fix HideBySig attributes on static constructors #383

Closed aarononeal closed 11 years ago

aarononeal commented 11 years ago

Static constructors have HideBySig on newer Mono versions but not on older ones. This patch allows Monobjc to match the appropriate convention used in compilation at runtime thereby resolving the test case failures.

letiemble commented 11 years ago

Now that Mono 3.x is the current stable release, is this still relevant to fix the behavior with Mono 2.x ?

aarononeal commented 11 years ago

In some embedded environments it's not possible to upgrade either the MDK or the MRE to a new build. So, it's still useful to compile and run Monobjc under 2.10 to verify compatibility. Without this fix, you'll see test failures when building under 2.10 regardless of runtime version, or when building with 3.2 and running on 2.10. Other than the test case failures, you're not going to see any real-world impact though. So, another option is to just doc these failures as expected in the readme and perhaps link to the patch (or patch branch) for anyone who wants to maintain a 2.10 build.

aarononeal commented 11 years ago

I ran some tests and 3 built assemblies running on 2 seems to be working OK, so I'll close this.