Add IsNative & fix multi-domain support

Monobjc / monobjc

Git Repository for the Monobjc Project

http://www.monobjc.net/

17 stars 3 forks source link

Add IsNative & fix multi-domain support #425

Closed aarononeal closed 10 years ago

aarononeal commented 11 years ago

This pull has two commits and deprecates pull https://github.com/Monobjc/monobjc/pull/405.

Add IsNative type marking (requires the related pull https://github.com/Monobjc/monobjc-tools/pull/23).
The second commit builds on IsNative to fix multi-domain support using tokens for name mangling.

aarononeal commented 10 years ago

I made an update to the IsNative commit today.

Removed the TestClassExistence test because it was redundant with the class hierarchy test and also failing when cls was null.
Added an ExpectedMissingTypes property to specify things like NSMenuView which is expected to be missing in AppKit 64-bit.

aarononeal commented 10 years ago

I made another small tweak to the second commit today to remove the code which set __pass_through_domain_actived to false when that domain shutdown. The flag must remain set because any types are still registered with Objective-C and so another domain coming up with a null token can't rely on those types. Leaving the flag set prevents this.

aarononeal commented 10 years ago

I just wanted to mention in case GitHub doesn't send a notice that I pushed an update a few days ago to address your feedback. Let me know if you need any more changes to the patch.

letiemble commented 10 years ago

Hi,

No need to change. I just lack time to merge the patch; 28 hours per day would be fine ;-)

Laurent.

2013/9/17 Aaron Oneal notifications@github.com

I just wanted to mention in case GitHub doesn't send a notice that I pushed an update a few days ago to address your feedback. Let me know if you need any more changes to the patch.

— Reply to this email directly or view it on GitHubhttps://github.com/Monobjc/monobjc/pull/425#issuecomment-24605385 .