search

Monogramm / taiga-contrib-ldap-auth-ext

:snake: :alembic: Extended Taiga plugin for LDAP authentication
http://taiga.io
GNU Affero General Public License v3.0
45 stars 15 forks source link

last commit will break? #33

Closed zakkg3 closed 4 years ago

zakkg3 commented 4 years ago

I am not 100% sure, but it seems to me that the last commit will break the code:

https://github.com/Monogramm/taiga-contrib-ldap-auth-ext/blob/7936d04144e736f8b7eb9ab23826bd489f8483f7/taiga_contrib_ldap_auth_ext/connector.py#L120-L121

Should this go back to:

  if len(c.response) == 0:

or:

if not c.response:
madmath03 commented 4 years ago

Hi @zakkg3 ,

Thank you for reporting this. You are probably right on this. We did not make a new release of this plugin because we did not had the time to test it and improve it further, but good job on finding that.

I think if not c.response: you mentioned should fix the expected behavior of the plugin.