Monogramm / taiga-contrib-ldap-auth-ext

:snake: :alembic: Extended Taiga plugin for LDAP authentication
http://taiga.io
GNU Affero General Public License v3.0
45 stars 15 forks source link

Rework README #52

Closed TuringTux closed 1 year ago

TuringTux commented 1 year ago

When I created a fork of this plugin, I also made some changes to the README to document my experiences with setting the plugin up. Now that all my code changes have been incorporated into this plugin, I'd like to discard my fork in an attempt to decrease entropy.

However, my README changes are not yet incorporated into this project, mostly because they are opinionated and also because they delete some content I found less relevant for my specific purpose.

I have opened this (draft) PR to evaluate the differences and then create a less-opinionated and complete version. After that, I would very much welcome your, @Monogramm's, feedback :)

madmath03 commented 1 year ago

Thanks a lot @TuringTux for this proposal. I really like your section about how to setup this plugin with the official Taiga docker image. I think we can add most of the original README's content to the "without docker section".

I will send some suggestions that you can apply / edit.

TuringTux commented 1 year ago

I've marked this as ready for review because as soon as the two change requests are finished, this can be merged from my side :)

madmath03 commented 1 year ago

Thanks @TuringTux for the support. PR merged.

TuringTux commented 1 year ago

Thanks @madmath03 for merging :)