search

Monokai / monokai-pro-vscode

Issue tracking for Monokai Pro for Visual Studio Code
321 stars 7 forks source link

Comments color having low contrast #224

Closed AnsonH closed 3 years ago

AnsonH commented 3 years ago

I think that the color of comments has very low contrast. They are often difficult to read, especially when my monitor's brightness is low. The color of comments (#727072) is kind of similar to the background of the editor:

Comments demonstration

When I inspect editor tokens in VS Code by running Developer: Inspect Editor Tokens and Scopes in the Command Palette (Ctrl + Shift + P), the contrast ratio of comments is only 2.89, which is low when we consider that W3C Standards suggests text should have contrast ratios of at least 4.5 for good accessibility.

I'm not sure whether comments are intentionally designed to have low contrast. However, I rely a lot on comments when I code and the low contrast color is making my life difficult. I'm a huge fan of this theme and I wish this issue can be solved.

Monokai commented 3 years ago

It's intentionally designed this way, so you can quickly browse through your code and visually "discard" the comments. I understand that some conditions (surrounding light / monitor settings) warrant higher contrast, but in my experience, adjusting the monitor brightness quickly solves it. If you like a bit more clarity, filter "Spectrum" has the highest contrast.

AnsonH commented 3 years ago

Thanks for the reply :) Let me close this issue since it's intentional design