Bad contrast colors in all variants in popups (vscode)

Monokai / monokai-pro-vscode

Issue tracking for Monokai Pro for Visual Studio Code

321 stars 8 forks source link

Bad contrast colors in all variants in popups (vscode) #355

Closed sztomi closed 1 year ago

sztomi commented 1 year ago

This is the "filter machine" variant, but all four looks similar (see the highlighted item in the popup which is almost unreadable):

The same in the Tokyo Night theme:

It almost seems like the text color is not set by either theme, but the selection background is. I don't know if this is related to Rust Analyzer itself which provides the completion, but I think this popup shows up via the LSP integration. Any way to fix this?

sztomi commented 1 year ago

@Monokai ?

Monokai commented 1 year ago

I'm seeing this (same for other filters):

The white color controlled by the editorSuggestWidget.highlightForeground property.

Do you have an override color in your user settings perhaps?

sztomi commented 1 year ago

Thanks for your reply - it turns out I did have a bunch of overrides for some reason (I don't remember setting them). Removed and all looks good!