search

Monokai / monokai-pro-vscode

Issue tracking for Monokai Pro for Visual Studio Code
321 stars 8 forks source link

Java Import Colors #374

Closed devondragon closed 6 months ago

devondragon commented 9 months ago

Revisiting #243 - perhaps this is no longer the case? Most of the other themes I have been using color the "import" keyword separately from the import class portion (see attached screenshot).

Screenshot 2023-09-09 at 6 36 53 PM

I would love to see this in Monokai Pro, as the all red lines are a bit jarring and make me think there is an error. Thanks!

Monokai commented 6 months ago

Well import is a keyword, like return or if or export. I think it's fine as it is.

devondragon commented 6 months ago

Right, but the class to import is NOT a keyword. So it shouldn't look the same. This is what is looks like in Monakai Pro:

Screenshot 2023-12-20 at 9 10 06 AM

Versus the other theme above, where you can clearly see the import keyword as distinct from the package and class.

You think it's better from a UI/UX perspective to be all the same color?

Monokai commented 6 months ago

Ah I see, I agree that's indeed too much, I didn't see it was Java and thought it was JavaScript. I'll update this.

devondragon commented 6 months ago

@Monokai - Looks like it's fixed in the latest update. Thank you very much!