Monokai / monokai-pro-vscode

Issue tracking for Monokai Pro for Visual Studio Code
321 stars 8 forks source link

feature request: more color distinction with JSDoc and decorator syntax #377

Open trusktr opened 9 months ago

trusktr commented 9 months ago

Hello! Paying customer here. Love the theme!

One thing I wish it had is more color for JSDoc parts and decorators.

Here's what it currently looks like:

Screenshot 2023-09-23 at 10 55 11 PM

Here's what it looks like with the Plastic theme:

Screenshot 2023-09-23 at 10 55 52 PM

The Plastic theme has more color for JSDoc tags, plus distinguishes the decorators from the property names (especially useful on single-line decorated properties).

If color is added for JSDoc parts, perhaps it can be a little dimmer than the regular color (more along the brighness of the comments). I don't think I've seen that before in a VS Code theme.

trusktr commented 9 months ago

Aha! It isn't that Plastic has extra rules for decorators, but it highlights functions in a different color using type information from TypeScript, and it so happens that decorators are functions. If you make a decorator type any, then Plastic no longer highlights it in function color:

Screenshot 2023-09-24 at 12 10 26 AM

I still think that perhaps it would still be nice to highlight decorators differently regardless, especially in cases where type info is not present (more likely in plain JS).