search

MonoliYoda / evve_dashboard_dev

0 stars 2 forks source link

esi_secrets.py contain more than just esi secrets #14

Open dgrif opened 4 years ago

dgrif commented 4 years ago

The file esi_secrets.py also has Django specific SECRET_KEY in it. For clarity it should probably be renamed to something more generic, perhaps just secrets.py and better comments around which secrets belong to what, and why. Thoughts?

SoCariEVE commented 4 years ago

Two options:

1) rename the file and add comments 2) separate into distinct files

I don't have a strong view either way. I'd probably err towards (1) and separate out in future if it seems necessary.