MonolithProjects / ansible-github_actions_runner

Ansible Role to deploy GitHub Actions self-hosted runner
https://galaxy.ansible.com/ui/standalone/roles/monolithprojects/github_actions_runner/
MIT License
190 stars 77 forks source link

Let "Replace runner" work with orgs #208

Closed Troels51 closed 5 months ago

Troels51 commented 5 months ago

Description

When replacing an existing runner, it makes no sense to restrict it to not run it on org runners. This commit removes that requirement. If there is a hidden assumption that requires it to not run on orgs, please let me know :)

Potentially closes: #207 and #198

Type of change

How Has This Been Tested?

I tested this by deploying the role to my infrastructure multiple times, with reinstall_runner: true Recreating a github runner is still "failing" because it is trying to redo the service files that are already installed, but it sets up the runner correctly

lewismiddleton commented 5 months ago

I think this resolves #145 too

MonolithProjects commented 5 months ago

Test pipeline was fine https://github.com/MonolithProjects/ansible-github_actions_runner/actions/runs/9211335164