Closed lewismiddleton closed 5 months ago
I think the custom_env
test scenario is broken because the verify.yaml
stage is expecting to find a runner called ubuntu16-latest
but this is not specified at the converge.yaml stage so defaults to the hostname (ubuntu22-latest
) .
Interestingly, there's a similar line in the default scenario's verify.yaml but this doesn't cause an error because it doesn't check the runners by name. This seems to be a change introduced in this commit.
I think the
custom_env
test scenario is broken because theverify.yaml
stage is expecting to find a runner calledubuntu16-latest
but this is not specified at the converge.yaml stage so defaults to the hostname (ubuntu22-latest
) .This results in an error Interestingly, there's a similar line in the default scenario's verify.yaml but this doesn't cause an error because it doesn't check the runners by name. This seems to be a change introduced in this commit.
Thx @lewismiddleton. That will be probably just some leftovers from my testing. I will look on it.
Description
Parameterises the
github_account
andgithub_repo
used in themolecule
test suite. Pulls these values from environment variables instead of hard coding. Had to change Github Workflows to account for this change.This makes testing more approachable for other contributors as they don't have to make changes to the working directory to run tests.
Type of change
How Has This Been Tested?
I've run all 4 test scenarios against a Github org that I maintain. 3 of them (
default
,repo
,org
) passed, thecustom_env
scenario failed for an unrelated reason, I'll add a comment to this PR explaining what I think the issue is.