search

MonsterEOS / monstereos

A Tamagotchi and Battle Game for EOS Blockchain :)
https://monstereos.io
MIT License
186 stars 61 forks source link

Make sure that death_at is set to the correct date once a monster died #90

Closed friedger closed 6 years ago

friedger commented 6 years ago

Currently, the monster.death_at field is only updated if the user interacts with the monster after it died.

There should be a mechanism to update that field, or remove that field alltogether.

leordev commented 6 years ago

this field is deprecated. I should rename it... for now just ignore this one, we don't use that for anything. the death must be calculated with globalconfig params

friedger commented 6 years ago

It is not that easy, as the parameters changed and might change in the future

Leo Ribeiro notifications@github.com schrieb am Mi., 19. Sep. 2018, 20:32:

this field is deprecated. I should rename it... for now just ignore this one, we don't use that for anything. the death must be calculated with globalconfig params

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MonsterEOS/monstereos/issues/90#issuecomment-422911226, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYcWYNKInDH2lJxOGGEH22HuaVstYs4ks5uco3ZgaJpZM4WwTyh .

leordev commented 6 years ago

I think the current global config is the valid one. Actually, you would need some kind of chain replay and keep track of global configs history to calculate whenever the parameters were changed... But even like that only the last global config param could be read by the contract and that is what will be applied in case of revive potion being used and if the pet dies again after starving for 72 hours (as now)...

let's not worry about it for now