Monstercraft / MonsterIRC

MonsterIRC's main repo.
Monstercraft.org
GNU General Public License v3.0
15 stars 7 forks source link

Messages sent through Herochat shortcuts are not relayed to IRC #248

Closed dwi closed 5 years ago

dwi commented 12 years ago

Using channel shortcuts for sending messages (like /l hello for message "hello" to local channel) is not relayed to IRC.

voshond commented 12 years ago

13:13:18 [INFO] [MonsterIRC] Invalid herochat channel detected for #playmcmmo

Same here. But i tripple checked. The Channel Global is def existing i just enabled Global and the Chan on IRC exist aswell. mcmmo Admin push to staff irc works.

fletchto99 commented 12 years ago

I've looked into this and it is actually a herochat issue. They are not firing a chat event when the shortcut is used therefore making it impossible for monsterirc to detect the chat without further hooking into herochat (which would not be the ideal way to go)

Go create a ticket on herochat asking them to fire a chat event when the channel shortcut is used.

dwi commented 12 years ago

Reply from Herochat dev:

There's no difference in how messages are handled between quick messages and normal chat. They all fire events. MonsterIRC is most likely not hooking the correct event.

We provide events for other plugins, (ChannelChatEvent) if they choose not to use it, then it wont transfer the chat.

fletchto99 commented 12 years ago

Ah they fire their own events okay. I'll get that sorted. Didn't realize this sorry.