search

Monstrofil / replays_unpack

51 stars 19 forks source link

Support for WoT replays v 1.10 #11

Open sbryk opened 3 years ago

sbryk commented 3 years ago

Hello,

do you plan to add support for WoT v 1.10? I'm trying to make it by myself, currently at figuring out how do you import game ressources. It seems to be a key for support different client versions.

Monstrofil commented 3 years ago

Hi, not really, but If you send me "scripts" folder (like this one https://github.com/Monstrofil/replays_unpack/tree/master/replay_unpack/clients/wot/versions/1_8_0/scripts) I will add it and make some instructions on how to add futher versions.

sbryk commented 3 years ago

Great! Here is the scripts folder for the current WoT client https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/tree/1.10/source/res/scripts

Monstrofil commented 3 years ago

Just added wot 1.10.0 support: https://github.com/Monstrofil/replays_unpack/commit/bc8e727208665156591bcb021f167360bd892d21

All steps needed to add new version:

Same thing can be done in examples/wot_parser, it just uses another (custom) definitions folder.

Monstrofil commented 3 years ago

Oh, it seems like decompiled files are little buggy and contain duplicates: https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/blob/1.10/source/res/scripts/entity_defs/Account.def https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/blob/1.10/source/res/scripts/entity_defs/account.def

Thus now parser works on Windows but not on Linux, I'll fix it later.

Reported initial issue in https://github.com/StranikS-Scan/WorldOfTanks-Decompiled/issues/6

StranikS-Scan commented 3 years ago

WG created this problem when it started renaming its files. Duplicates are created by github automatically on the server. To fix the problems I need to create a new repo. However, when WG renames another part of the files again, the problem will appear again .... Use the archive from the zip\ folder, it always contains files with the correct names.